There is a legacy file called remove_cruft.sh that is run when a new config tarball is deployed. The intent of this script is to remove paddle files that are no longer in use.
While having stale paddles does not affect operation, leaving old paddle files that are no longer in service could potentially be used by a driver to log in and use that paddle. This could reasonably happen if there is a service switch over and the driver inadvertently uses an old paddle they are used to rather than using a new one.
In order to minimize stale paddle usage, the remove_cruft.sh script should be run to remove paddles no longer in service.
Both the apply_update_legacy.sh and the apply_update_popufare.sh script should be updated to run the remove_cruft.sh script should it be available.
priority
medium
estimate
3 work units
There is a legacy file called `remove_cruft.sh` that is run when a new config tarball is deployed. The intent of this script is to remove paddle files that are no longer in use.
While having stale paddles does not affect operation, leaving old paddle files that are no longer in service could potentially be used by a driver to log in and use that paddle. This could reasonably happen if there is a service switch over and the driver inadvertently uses an old paddle they are used to rather than using a new one.
In order to minimize stale paddle usage, the `remove_cruft.sh` script should be run to remove paddles no longer in service.
Both the `apply_update_legacy.sh` and the `apply_update_popufare.sh` script should be updated to run the `remove_cruft.sh` script should it be available.
| | |
|---|---|
| priority | medium |
| estimate | 3 work units |
The remove_cruft.sh script is packaged into the install.sh script deployed in the config tarball. This means that if the install.sh script is run local on the DIU, the remove_cruft.sh script is run.
Due to incompatibility, the updated DIUs running Popufare will not run the install.sh script destined for legacy systems, which means they effecitvely won't run the remove_cruft.sh script.
For new installs, the Popufare DIUs will, assuming the install.sh script is present and the popufare.witness file is present in the config tarball, indicating an updated config file installation.
This means that legacy DIUs will still run the remove_cruft.sh script, Popufare DIUs will run the remove_cruft.sh script with config tarballs destined for Popufare DIUs but Popufare DIUs will not run the remove_cruft.sh script for legacy config tarballs.
So the fix is to have the legacy install specifically target the remove_cruft.sh script, if possible, and run it locally under the specific condition that it's a Popufare DIU running a legacy config install. The legacy installation might assume too much context from the legacy system so there might be a compromise to update the server config packaging to include an auxiliary script that doesn't get run on the legacy system but will get run on the Popufare DIUs to target these stale paddles.
Considering this is essentially an issue with transitioning from the legacy system to the Popufare system, this will be degraded to low priority. This can be escalated should this prove to become a problem.
The `remove_cruft.sh` script is packaged into the `install.sh` script deployed in the config tarball. This means that if the `install.sh` script is run local on the DIU, the `remove_cruft.sh` script is run.
Due to incompatibility, the updated DIUs running Popufare will not run the `install.sh` script destined for legacy systems, which means they effecitvely won't run the `remove_cruft.sh` script.
For new installs, the Popufare DIUs will, assuming the `install.sh` script is present and the `popufare.witness` file is present in the config tarball, indicating an updated config file installation.
This means that legacy DIUs will still run the `remove_cruft.sh` script, Popufare DIUs will run the `remove_cruft.sh` script with config tarballs destined for Popufare DIUs but Popufare DIUs will not run the `remove_cruft.sh` script for legacy config tarballs.
So the fix is to have the legacy install specifically target the `remove_cruft.sh` script, if possible, and run it locally under the specific condition that it's a Popufare DIU running a legacy config install. The legacy installation might assume too much context from the legacy system so there might be a compromise to update the server config packaging to include an auxiliary script that doesn't get run on the legacy system but will get run on the Popufare DIUs to target these stale paddles.
Considering this is essentially an issue with transitioning from the legacy system to the Popufare system, this will be degraded to low priority. This can be escalated should this prove to become a problem.
There is a legacy file called
remove_cruft.shthat is run when a new config tarball is deployed. The intent of this script is to remove paddle files that are no longer in use.While having stale paddles does not affect operation, leaving old paddle files that are no longer in service could potentially be used by a driver to log in and use that paddle. This could reasonably happen if there is a service switch over and the driver inadvertently uses an old paddle they are used to rather than using a new one.
In order to minimize stale paddle usage, the
remove_cruft.shscript should be run to remove paddles no longer in service.Both the
apply_update_legacy.shand theapply_update_popufare.shscript should be updated to run theremove_cruft.shscript should it be available.The
remove_cruft.shscript is packaged into theinstall.shscript deployed in the config tarball. This means that if theinstall.shscript is run local on the DIU, theremove_cruft.shscript is run.Due to incompatibility, the updated DIUs running Popufare will not run the
install.shscript destined for legacy systems, which means they effecitvely won't run theremove_cruft.shscript.For new installs, the Popufare DIUs will, assuming the
install.shscript is present and thepopufare.witnessfile is present in the config tarball, indicating an updated config file installation.This means that legacy DIUs will still run the
remove_cruft.shscript, Popufare DIUs will run theremove_cruft.shscript with config tarballs destined for Popufare DIUs but Popufare DIUs will not run theremove_cruft.shscript for legacy config tarballs.So the fix is to have the legacy install specifically target the
remove_cruft.shscript, if possible, and run it locally under the specific condition that it's a Popufare DIU running a legacy config install. The legacy installation might assume too much context from the legacy system so there might be a compromise to update the server config packaging to include an auxiliary script that doesn't get run on the legacy system but will get run on the Popufare DIUs to target these stale paddles.Considering this is essentially an issue with transitioning from the legacy system to the Popufare system, this will be degraded to low priority. This can be escalated should this prove to become a problem.